Fix environment-only Dockerfile builds - #47
Merged
realrajaryan merged 2 commits intoOct 30, 2025
Merged
Conversation
wlan0
reviewed
Oct 30, 2025
|
|
||
| // OCI manifests require a layers array (cannot be null) | ||
| stateWithLayer := llb.Scratch(). | ||
| File(llb.Mkfile("/.container-metadata-only", 0644, []byte("# This image contains only metadata (ENV/ARG/LABEL)\n"))). |
Contributor
There was a problem hiding this comment.
Use a constant for marker path, that way it is self-documenting
const metadataOnlyMarker = "/.container-metadata-only"use that const instead of the literal
wlan0
approved these changes
Oct 30, 2025
dcantah
approved these changes
Oct 30, 2025
7 tasks
jglogan
pushed a commit
to apple/container
that referenced
this pull request
Oct 30, 2025
- Fixes #736. - BuildKit returns nil ref for Dockerfiles containing only metadata (`ENV/ARG/LABEL`) directives without filesystem operations (`RUN/COPY/ADD`). Previously, this caused builds to fail with "no build directives" error. - Builder-shim 0.6.3 [fixes this](apple/container-builder-shim#47) by creating a minimal marker layer when ref is nil but image config is valid, satisfying OCI manifest requirements. - Also, added some tests for this behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Dockerfile only includes metadata directives like
ENV, ARG, or LABELand doesn’t perform any filesystem operations (RUN, COPY, ADD), BuildKit ends up returning a nil ref. Our builder currently treats that as an error, which blocks these metadata only Dockerfiles from building.This PR makes the builder handle that case gracefully by creating a small marker layer (
/.container-metadata-only) when ref is nil but the image is otherwise valid. That satisfies OCI manifest requirements and ensures the Swift decoder always gets a valid layers array instead of null, allowing metadata only Dockerfiles to build as expected.