Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 41 additions & 2 deletions pkg/build/frontend.go
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,15 @@ func resolveStates(ctx context.Context, bopts *BOpts, platform ocispecs.Platform
return nil, err
}

stages, _, err := instructions.Parse(dockerfile.AST, nil)
stages, metaArgs, err := instructions.Parse(dockerfile.AST, nil)
if err != nil {
return nil, err
}

shlex := shell.NewLex(dockerfile.EscapeToken)
resolvedGlobalArgs := globalArgs(bopts.BuildPlatforms[0], platform, bopts.BuildArgs, bopts.Target)
// Merge pre-FROM ARG defaults so FROM references can expand correctly.
resolvedGlobalArgs, err = resolveMetaArgs(resolvedGlobalArgs, metaArgs, bopts.BuildArgs, shlex)
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -208,7 +216,6 @@ func resolveStates(ctx context.Context, bopts *BOpts, platform ocispecs.Platform
defer wg.Done()

shlex := shell.NewLex(dockerfile.EscapeToken)
resolvedGlobalArgs := globalArgs(bopts.BuildPlatforms[0], platform, bopts.BuildArgs, bopts.Target)
resolvedBaseStageName, err := shlex.ProcessWordWithMatches(stage.BaseName, resolvedGlobalArgs)
if err != nil {
errCh <- fmt.Errorf("invalid arg for stage[%s]: %v", stage.BaseName, err)
Expand Down Expand Up @@ -481,3 +488,35 @@ func globalArgs(buildPlatform, targetPlatform ocispecs.Platform, buildArgs map[s
}
return utils.NewMapGetter(args)
}

// resolveMetaArgs applies Dockerfile ARG defaults in declaration order while preserving explicit build arg overrides.
func resolveMetaArgs(args utils.MapGetter, metaArgs []instructions.ArgCommand, buildArgs map[string]string, shlex *shell.Lex) (utils.MapGetter, error) {
resolved := map[string]string{}
for _, k := range args.Keys() {
v, ok := args.Get(k)
if ok {
resolved[k] = v
}
}

for _, cmd := range metaArgs {
for _, arg := range cmd.Args {
// Explicit build args override Dockerfile defaults.
if v, ok := buildArgs[arg.Key]; ok {
resolved[arg.Key] = v
continue
}
if arg.Value == nil {
continue
}

expanded, err := shlex.ProcessWordWithMatches(*arg.Value, utils.NewMapGetter(resolved))
if err != nil {
return nil, err
}
resolved[arg.Key] = expanded.Result
}
}

return utils.NewMapGetter(resolved), nil
}