Skip to content

Centralize utilities for configuration loading and path parsing#1448

Open
noah-thor wants to merge 1 commit intoapple:mainfrom
noah-thor:user-config-utility-no-toml
Open

Centralize utilities for configuration loading and path parsing#1448
noah-thor wants to merge 1 commit intoapple:mainfrom
noah-thor:user-config-utility-no-toml

Conversation

@noah-thor
Copy link
Copy Markdown
Contributor

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Motivation and Context

This attempts to create a more centralized utility to find and load configuration files, as a follow up to (pr: #1425).

This would make the file apis look something like:

let configPath = UserConfiguration.basePath(for: .appRoot).appending("config/config.toml")

Testing

  • Tested locally
  • Added/updated tests
  • Added/updated docs

@noah-thor
Copy link
Copy Markdown
Contributor Author

Mainly looking for API feedback, changes will not be mergable until TOML PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants