[network-creation]: Add createdAt field

[saehejkang]

Type of Change

• Bug fix
• New feature
• Breaking change
• Documentation update

Motivation and Context

Closes #665

Testing

• Tested locally
• Added/updated tests
• Added/updated docs

[saehejkang]

Not sure if I added the createdAt field correctly to the decoder, but I am getting an error when testing any network commands.

Error: keyNotFound(CodingKeys(stringValue: "createdAt", intValue: nil), Swift.DecodingError.Context(codingPath: [CodingKeys(stringValue: "running", intValue: nil), RunningCodingKeys(stringValue: "_0", intValue: nil)], debugDescription: "No value associated with key CodingKeys(stringValue: \"createdAt\", intValue: nil) (\"createdAt\").", underlyingError: nil))

Maybe something to do with the encoding and decoding done in the create function here? First time looking into the api/client side of things.

[saehejkang]

Not sure the protocol with pinging maintainers, as I don't want to bloat anyone's notifications.

But @jglogan , I would love to get some 👀 on this. Mainly to check if I am even taking the right steps in what we want accomplish here.

[jglogan]

@saehejkang I'll have a look next week.

[jglogan]

@saehejkang I'll have a review of this done by the end of the day. The main thing I want to consider is whether what you have here follows a pattern that we can apply to the metadata for all our managed resources.

[jglogan]

This pattern could get out of hand as we add more configuration attributes.

Perhaps we could have a public var configuration: NetworkConfiguration? that provides configuration if the state has that associated data (always would for now but it would give us leeway for states that don't)?

[saehejkang]

I think I understand what you kinda mean? Do we want to update id as well?

public var configuration: NetworkConfiguration? {
   switch self {
      case .created(let configuration): configuration
      case .running(let configuration, _): configuration
   }
}

public var createdAt: Date? {
   configuration?.createdAt
}

[jglogan]

We don't need this in PrintableNetwork if we're not printing it for now, right?

Let's leave it out here and not print the create date in tabular output, to start with.

[saehejkang]

#791 (comment)