Add Docker credential helper support for dynamic registry authentication #831
+365
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add DockerConfigReader to parse ~/.docker/config.json - Add CredentialHelperExecutor to invoke docker-credential-* helpers - Integrate credential helpers into ImageService authentication flow - Add tests for DockerConfig and CredentialHelper functionality Co-authored-by: imjasonh <[email protected]>
Co-authored-by: imjasonh <[email protected]>
Use defer block to ensure file handle is properly closed even if operations fail Co-authored-by: imjasonh <[email protected]>
Validate helper names to only allow alphanumeric characters, hyphens, and underscores to prevent potential command injection vulnerabilities Co-authored-by: imjasonh <[email protected]>
Move file handle close to execute immediately after write operation to ensure proper sequencing and cleanup Co-authored-by: imjasonh <[email protected]>
- Add descriptive @test annotations to all test methods - Add blank lines between test methods for readability - Add additional test cases for helper name validation - Add test for empty credHelpers configuration - Apply swift-format to ensure consistent code style - Reorder imports alphabetically per style guide Co-authored-by: imjasonh <[email protected]>
…port Add Docker credential helper support for dynamic registry authentication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Context: #820
Testing