UnixSocketConfiguration: Change from/to to source/destination#22
Merged
crosbymichael merged 1 commit intomainfrom Jun 5, 2025
Merged
UnixSocketConfiguration: Change from/to to source/destination#22crosbymichael merged 1 commit intomainfrom
crosbymichael merged 1 commit intomainfrom
Conversation
Member
Author
|
One sec, forgot to add some changes from other files |
This is something I forgot to update ages ago. The field names, while they do make sense, were different than the constructor names that eventually set the fields themselves. This is kind of awkward, and I'd much rather fix this now while it's much easier. Signed-off-by: Danny Canter <danny_canter@apple.com>
009e234 to
7d560cc
Compare
crosbymichael
approved these changes
Jun 5, 2025
katiewasnothere
pushed a commit
that referenced
this pull request
Jun 5, 2025
This is something I forgot to update ages ago. The field names, while they do make sense, were different than the constructor names that eventually set the fields themselves. This is kind of awkward, and I'd much rather fix this now while it's much easier. We'll need to update `container` after this Signed-off-by: Danny Canter <danny_canter@apple.com>
katiewasnothere
pushed a commit
that referenced
this pull request
Jun 5, 2025
This is something I forgot to update ages ago. The field names, while they do make sense, were different than the constructor names that eventually set the fields themselves. This is kind of awkward, and I'd much rather fix this now while it's much easier. We'll need to update `container` after this Signed-off-by: Danny Canter <danny_canter@apple.com>
katiewasnothere
added a commit
to apple/container
that referenced
this pull request
Jun 6, 2025
Update containerization to take new breaking changes apple/containerization#22 Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
owenarthur
pushed a commit
to owenarthur/container
that referenced
this pull request
Jun 10, 2025
Update containerization to take new breaking changes apple/containerization#22 Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
dkovba
added a commit
to dkovba/containerization
that referenced
this pull request
Mar 5, 2026
dkovba
added a commit
to dkovba/containerization
that referenced
this pull request
Mar 5, 2026
dkovba
added a commit
to dkovba/containerization
that referenced
this pull request
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is something I forgot to update ages ago. The field names, while they do make sense, were different than the constructor names that eventually set the fields themselves. This is kind of awkward, and I'd much rather fix this now while it's much easier.
We'll need to update
containerafter this