Skip to content

UnixSocketConfiguration: Change from/to to source/destination#22

Merged
crosbymichael merged 1 commit intomainfrom
unixsocket-configuration-amendments
Jun 5, 2025
Merged

UnixSocketConfiguration: Change from/to to source/destination#22
crosbymichael merged 1 commit intomainfrom
unixsocket-configuration-amendments

Conversation

@dcantah
Copy link
Copy Markdown
Member

@dcantah dcantah commented Jun 5, 2025

This is something I forgot to update ages ago. The field names, while they do make sense, were different than the constructor names that eventually set the fields themselves. This is kind of awkward, and I'd much rather fix this now while it's much easier.

We'll need to update container after this

@dcantah
Copy link
Copy Markdown
Member Author

dcantah commented Jun 5, 2025

One sec, forgot to add some changes from other files

This is something I forgot to update ages ago. The field names,
while they do make sense, were different than the constructor
names that eventually set the fields themselves. This is kind of
awkward, and I'd much rather fix this now while it's much easier.

Signed-off-by: Danny Canter <danny_canter@apple.com>
@dcantah dcantah force-pushed the unixsocket-configuration-amendments branch from 009e234 to 7d560cc Compare June 5, 2025 03:54
@crosbymichael crosbymichael merged commit 05498d9 into main Jun 5, 2025
2 checks passed
@crosbymichael crosbymichael deleted the unixsocket-configuration-amendments branch June 5, 2025 16:24
katiewasnothere pushed a commit that referenced this pull request Jun 5, 2025
This is something I forgot to update ages ago. The field names, while
they do make sense, were different than the constructor names that
eventually set the fields themselves. This is kind of awkward, and I'd
much rather fix this now while it's much easier.

We'll need to update `container` after this

Signed-off-by: Danny Canter <danny_canter@apple.com>
katiewasnothere pushed a commit that referenced this pull request Jun 5, 2025
This is something I forgot to update ages ago. The field names, while
they do make sense, were different than the constructor names that
eventually set the fields themselves. This is kind of awkward, and I'd
much rather fix this now while it's much easier.

We'll need to update `container` after this

Signed-off-by: Danny Canter <danny_canter@apple.com>
katiewasnothere added a commit to apple/container that referenced this pull request Jun 6, 2025
Update containerization to take new breaking changes
apple/containerization#22

Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
owenarthur pushed a commit to owenarthur/container that referenced this pull request Jun 10, 2025
Update containerization to take new breaking changes
apple/containerization#22

Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
dkovba added a commit to dkovba/containerization that referenced this pull request Mar 5, 2026
dkovba added a commit to dkovba/containerization that referenced this pull request Mar 5, 2026
dkovba added a commit to dkovba/containerization that referenced this pull request Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants