Skip to content

Resolve a compilation error and warnings in make test #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
katiewasnothere merged 3 commits into from
Jun 6, 2025
Merged

Resolve a compilation error and warnings in make test #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ffbcc2d
Remove a not used import to fix a compilation error
dkovba Jun 6, 2025
4f45212
Fix warnings about not used constants
dkovba Jun 6, 2025
df2ad7d
Make a thread-safe constant non-isolated to silence a warning
dkovba Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Sources/Integration/Suite.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,9 @@ struct IntegrationSuite: AsyncParsableCommand {
}()

private static var authentication: Authentication? {
guard let password = ProcessInfo.processInfo.environment["REGISTRY_TOKEN"],
let username = ProcessInfo.processInfo.environment["REGISTRY_USERNAME"]
let env = ProcessInfo.processInfo.environment
guard let password = env["REGISTRY_TOKEN"],
let username = env["REGISTRY_USERNAME"]
else {
return nil
}
Expand Down
2 changes: 0 additions & 2 deletions Tests/ContainerizationExtrasTests/UInt8+DataBindingTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@

import Testing

@testable import ContainerizationNetlink

struct BufferTest {
@Test func testBufferBind() throws {
let expectedValue: UInt64 = 0x0102_0304_0506_0708
Expand Down
4 changes: 2 additions & 2 deletions Tests/ContainerizationOCITests/RegistryClientTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,8 +308,8 @@ struct OCIClientTests: ~Copyable {

static var authentication: Authentication? {
let env = ProcessInfo.processInfo.environment
guard let password = ProcessInfo.processInfo.environment["REGISTRY_TOKEN"],
let username = ProcessInfo.processInfo.environment["REGISTRY_USERNAME"]
guard let password = env["REGISTRY_TOKEN"],
let username = env["REGISTRY_USERNAME"]
else {
return nil
}
Expand Down
4 changes: 2 additions & 2 deletions Tests/ContainerizationTests/ImageTests/ContainsAuth.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ extension ContainsAuth {

static var authentication: Authentication? {
let env = ProcessInfo.processInfo.environment
guard let password = ProcessInfo.processInfo.environment["REGISTRY_TOKEN"],
let username = ProcessInfo.processInfo.environment["REGISTRY_USERNAME"]
guard let password = env["REGISTRY_TOKEN"],
let username = env["REGISTRY_USERNAME"]
else {
return nil
}
Expand Down
3 changes: 2 additions & 1 deletion Tests/SendablePropertyMacrosTests/SendablePropertyMacrosTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ import XCTest
#if canImport(SendablePropertyMacros)
import SendablePropertyMacros

let testMacros: [String: Macro.Type] = [
// testMacros is thread-safe.
nonisolated(unsafe) let testMacros: [String: Macro.Type] = [
"SendableProperty": SendablePropertyMacro.self
]
#endif
Expand Down