Socket: Add fd receiving #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcantah
force-pushed
the
socket-scmrights
branch
from
28e94ef to
30db209
Compare
dcantah
commented
Oct 14, 2025
|
|
||
| #include "socket_helpers.h" | ||
|
|
||
| struct cmsghdr* CZ_CMSG_FIRSTHDR(struct msghdr *msg) { |
There was a problem hiding this comment.
Only reason is you can't call c macros in swift. So they need to be wrapped in a function we actually can.
| let data = try receivedFileHandle.readToEnd() | ||
| #expect(data != nil, "Should be able to read from received FD") | ||
|
|
||
| let receivedContent = String(data: data!, encoding: .utf8) |
There was a problem hiding this comment.
Just a heads up that a failed #expect does not end the test. If the above check that data != nil fails, we will still get to this line, which I'm assuming may panic since data is nil.
katiewasnothere
approved these changes
Oct 14, 2025
dcantah
force-pushed
the
socket-scmrights
branch
from
30db209 to
96e1046
Compare
katiewasnothere
approved these changes
Oct 14, 2025
Via scm_rights. Useful for supporting spawning runc as an OCI runtime as that's how the pty is passed to the client.
dcantah
force-pushed
the
socket-scmrights
branch
from
96e1046 to
93d120f
Compare
katiewasnothere
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via scm_rights. Useful for supporting spawning runc as an OCI runtime as that's how the pty is passed to the client.