-
Notifications
You must be signed in to change notification settings - Fork 141
Fix forced_decoder_ids parsing for HuggingFace generation config, and add SpeechTests target #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+103
−1
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ed7ebe4
Fix forced_decoder_ids parsing for HuggingFace generation config
stikves 9a67dd9
Fix Swift format
stikves c755651
Merge branch 'main' into sukru/fix-speech-decoder-ids
stikves 5a824b2
Merge branch 'main' into sukru/fix-speech-decoder-ids
stikves File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| // Copyright 2026 Apple Inc. | ||
| // | ||
| // Use of this source code is governed by a BSD-3-clause license that can | ||
| // be found in the LICENSE file or at https://opensource.org/licenses/BSD-3-Clause | ||
|
|
||
| import Foundation | ||
| import Testing | ||
|
|
||
| @testable import CoreAISpeech | ||
|
|
||
| @Suite("GenerationConfig") | ||
| struct GenerationConfigTests { | ||
| @Test("Parses forced_decoder_ids from HuggingFace format") | ||
| func parseForcedDecoderIds() throws { | ||
| let json: [String: Any] = [ | ||
| "forced_decoder_ids": [[1, 50258], [2, 50259], [3, 50360], [4, 50364]], | ||
| "eos_token_id": 50257, | ||
| "max_new_tokens": 100, | ||
| ] | ||
| let data = try JSONSerialization.data(withJSONObject: json) | ||
| let url = FileManager.default.temporaryDirectory.appendingPathComponent("gen_config.json") | ||
| try data.write(to: url) | ||
| defer { try? FileManager.default.removeItem(at: url) } | ||
|
|
||
| let config = try GenerationConfig(from: url) | ||
| #expect(config.forcedPrefix == [50258, 50259, 50360, 50364]) | ||
| #expect(config.eotToken == 50257) | ||
| #expect(config.maxDecodeSteps == 100) | ||
| } | ||
|
|
||
| @Test("Falls back to Whisper defaults when forced_decoder_ids is missing") | ||
| func fallbackOnMissingField() throws { | ||
| let json: [String: Any] = ["eos_token_id": 50257] | ||
| let data = try JSONSerialization.data(withJSONObject: json) | ||
| let url = FileManager.default.temporaryDirectory.appendingPathComponent("gen_config2.json") | ||
| try data.write(to: url) | ||
| defer { try? FileManager.default.removeItem(at: url) } | ||
|
|
||
| let config = try GenerationConfig(from: url) | ||
| #expect(config.forcedPrefix == GenerationConfig.whisper.forcedPrefix) | ||
| } | ||
|
|
||
| @Test("Falls back to Whisper defaults when forced_decoder_ids has wrong format") | ||
| func fallbackOnWrongFormat() throws { | ||
| let json: [String: Any] = [ | ||
| "forced_decoder_ids": [50258, 50259, 50360] // flat array, not pairs | ||
| ] | ||
| let data = try JSONSerialization.data(withJSONObject: json) | ||
| let url = FileManager.default.temporaryDirectory.appendingPathComponent("gen_config3.json") | ||
| try data.write(to: url) | ||
| defer { try? FileManager.default.removeItem(at: url) } | ||
|
|
||
| let config = try GenerationConfig(from: url) | ||
| #expect(config.forcedPrefix == GenerationConfig.whisper.forcedPrefix) | ||
| } | ||
|
|
||
| @Test("Skips null token IDs in forced_decoder_ids pairs") | ||
| func skipsNullTokenIds() throws { | ||
| let json: [String: Any] = [ | ||
| "forced_decoder_ids": [[1, NSNull()], [2, 50360], [3, 50364]] | ||
| ] | ||
| let data = try JSONSerialization.data(withJSONObject: json) | ||
| let url = FileManager.default.temporaryDirectory.appendingPathComponent("gen_config4.json") | ||
| try data.write(to: url) | ||
| defer { try? FileManager.default.removeItem(at: url) } | ||
|
|
||
| let config = try GenerationConfig(from: url) | ||
| #expect(config.forcedPrefix == [50360, 50364]) | ||
| } | ||
|
|
||
| @Test("Handles out-of-order positions") | ||
| func outOfOrderPositions() throws { | ||
| let json: [String: Any] = [ | ||
| "forced_decoder_ids": [[3, 50360], [1, 50258], [2, 50259]] | ||
| ] | ||
| let data = try JSONSerialization.data(withJSONObject: json) | ||
| let url = FileManager.default.temporaryDirectory.appendingPathComponent("gen_config5.json") | ||
| try data.write(to: url) | ||
| defer { try? FileManager.default.removeItem(at: url) } | ||
|
|
||
| let config = try GenerationConfig(from: url) | ||
| #expect(config.forcedPrefix == [50258, 50259, 50360]) | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.