Skip to content

Check for end-of-turn tokens in tokenizer config top-level #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lewis300 merged 3 commits into from
Aug 7, 2026
Merged

Check for end-of-turn tokens in tokenizer config top-level #155

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8becce2
Also look for end of turn tokens in the top level of the tokenizer_co…
Lewis300 Aug 5, 2026
6f9b6b8
Add unit tests for additionalStopTokens func
Lewis300 Aug 6, 2026
c6b38f3
Merge branch 'main' into extra-eot-check
Lewis300 Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion swift/Sources/CoreAILanguageModels/Bundle/LanguageConfig.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ public struct LanguageConfig: Codable, Sendable, Equatable {
// 3. Check added_tokens_decoder for turn-ending special tokens
// (e.g. Gemma's <end_of_turn> ID 106, Qwen's <|im_end|>)
// Only include tokens whose content matches known turn-ending patterns.
let turnEndPatterns = ["end_of_turn", "im_end", "eot_id", "endoftext"]
let turnEndPatterns = ["end_of_turn", "im_end", "eot_id", "endoftext", "eot_token"]
if let addedTokens = json["added_tokens_decoder"] as? [String: Any] {
for (idString, value) in addedTokens {
guard let dict = value as? [String: Any],
Expand All @@ -149,6 +149,18 @@ public struct LanguageConfig: Codable, Sendable, Equatable {
}
}

// 4. Check for turn-ending tokens in in top level of config
for turnEndPattern in turnEndPatterns {
if let eotToken = json[turnEndPattern] as? String {
if let id = tokenizer.convertTokenToId(eotToken) {
let id32 = Int32(id)
if id32 != mainEos {
result.insert(id32)
}
}
}
}

return Array(result)
}
}
Expand Down