Skip to content

Commit 1001e57

Browse files
authored
test: unskip eager CoreML int8-activation export tests as they now pass (#36)
COREML_SUPPORTED_ACTIVATION_DTYPES already includes torch.int8 (src/coreai_opt/_utils/export_utils.py), and the CoreML rejection test (test_unsupported_activation_quant_coreml_export_rejected) already excludes int8 from its rejection list. The skip_if_unsupported guards in test_simple_model_export and test_mnist_export were stale relative to the source's own dtype-support contract. Verified all 216 previously-skipped configs now pass (CPU_ONLY, the only compute path this test file exercises).
1 parent 61d7084 commit 1001e57

1 file changed

Lines changed: 0 additions & 14 deletions

File tree

tests/export/test_eager_mil_export.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -94,13 +94,6 @@ def test_simple_model_export(
9494
parametrized_quant_config_general: ParametrizedQuantConfigs,
9595
) -> None:
9696
"""Test eager CoreML export with various quantization configurations."""
97-
# CoreML doesn't support int8 activation quantization
98-
parametrized_quant_config_general.skip_if_unsupported(
99-
"eager",
100-
ExportBackend.CoreML,
101-
unsupported_configs={"backend": ExportBackend.CoreML, "act_dtype": torch.int8},
102-
)
103-
10497
has_act_quant = parametrized_quant_config_general.has_activation_quantization
10598

10699
_run_eager_mil_export_test(
@@ -121,13 +114,6 @@ def test_mnist_export(
121114
parametrized_quant_config_general: ParametrizedQuantConfigs,
122115
) -> None:
123116
"""Test eager CoreML export on MNIST model with various quantization configurations."""
124-
# CoreML doesn't support int8 activation quantization
125-
parametrized_quant_config_general.skip_if_unsupported(
126-
"eager",
127-
ExportBackend.CoreML,
128-
unsupported_configs={"backend": ExportBackend.CoreML, "act_dtype": torch.int8},
129-
)
130-
131117
has_act_quant = parametrized_quant_config_general.has_activation_quantization
132118

133119
_run_eager_mil_export_test(

0 commit comments

Comments
 (0)