Skip to content

ci: add ubuntu-latest test pipelines - #19

Merged
guru-desh merged 7 commits into
apple:mainfrom
guru-desh:u/gurudesh/make-test-suite-pass-for-linux
Jul 1, 2026
Merged

ci: add ubuntu-latest test pipelines#19
guru-desh merged 7 commits into
apple:mainfrom
guru-desh:u/gurudesh/make-test-suite-pass-for-linux

Conversation

@guru-desh

@guru-desh guru-desh commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Adds new Linux CI pipelines for the following:

  1. make test-smoke
  2. make test-tutorials
  3. All 4 highest/lowest + slow/fast test pipelines

The following CI pipelines were edited:

  1. make check now runs on Linux

@guru-desh
guru-desh force-pushed the u/gurudesh/make-test-suite-pass-for-linux branch from 9a50a0a to 883ce88 Compare June 30, 2026 21:17
@guru-desh guru-desh added the enhancement New feature or request label Jun 30, 2026
@guru-desh
guru-desh requested review from aseemw and dengqiaoyu June 30, 2026 21:18
@guru-desh guru-desh changed the title ci: add ubuntu-latest test pipelines ci: add ubuntu-latest test pipelines Jun 30, 2026
@guru-desh
guru-desh force-pushed the u/gurudesh/make-test-suite-pass-for-linux branch 2 times, most recently from a7c6cb5 to e3e9072 Compare June 30, 2026 21:33
@guru-desh
guru-desh marked this pull request as ready for review June 30, 2026 21:34
dengqiaoyu
dengqiaoyu previously approved these changes Jun 30, 2026
@madrob

madrob commented Jun 30, 2026

Copy link
Copy Markdown

Can we expand this to run on linux/arm64? I was trying to verify the linux tests on a linux container on my M4 laptop, and couldn't get past the platform check.

Add 4 GitHub-hosted Linux pipelines that run on ubuntu-latest:
- highest-torch slow, highest-torch fast
- lowest-torch slow, lowest-torch fast

Each runs the corresponding make target with --junit and uploads its
test-results artifact. Ungated and independent of the macOS self-hosted
jobs so they also run on forks.
Introduce a tiered CI structure:
- Tier 1 (ubuntu-latest, ungated): make check, make test-smoke,
  make test-tutorials.
- Tier 2 (needs all of Tier 1): the 4 linux test pipelines and the
  macOS test run.

Move `check` off the macOS self-hosted runner to ubuntu-latest and drop
its repo gate so the gate also runs on forks (otherwise Tier 2 would be
skipped there). test-smoke/test-tutorials targets are added by a
separate change; until then those jobs fail and Tier 2 is skipped.
Port the scripts/make changes from coreai-opt#497 so INSTALL_PRECOMMIT
is a real knob: setup_env.sh defaults it (false in --ensure mode, true
otherwise) and threads it to install_pre_commit_hooks.sh, which skips
`pre-commit install -f` when INSTALL_PRECOMMIT=false.
Skip git-hook configuration during env setup for the 4 linux test jobs,
the macOS test run, test-smoke, and test-tutorials. `check` is left as-is.
GitHub Actions doesn't support YAML anchors, so collapse the 4 linux-*
test jobs into a single `linux-tests` job with a strategy.matrix over
{highest,lowest} x {slow,fast}, declaring needs:/env:/steps once. Also
drop the redundant "Stage 2 runs only if..." comment.
@guru-desh
guru-desh force-pushed the u/gurudesh/make-test-suite-pass-for-linux branch from e3e9072 to 3647512 Compare June 30, 2026 22:55
Comment thread .github/workflows/ci.yaml
@guru-desh
guru-desh force-pushed the u/gurudesh/make-test-suite-pass-for-linux branch from 3647512 to 442ff94 Compare June 30, 2026 23:31
@guru-desh

Copy link
Copy Markdown
Contributor Author

Can we expand this to run on linux/arm64? I was trying to verify the linux tests on a linux container on my M4 laptop, and couldn't get past the platform check.

coreai-core doesn't release linux arm64 wheels, so resolution would fail in the container. If you really wanted to run tests in a linux container, you would need to set --platform linux/amd64.

@guru-desh
guru-desh merged commit a87b440 into apple:main Jul 1, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants