Skip to content

Guard Resolver Private Mutations Work #12498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+26 −17
Open

Guard Resolver Private Mutations Work #12498

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
64d056f
Guard Resolver Private Mutations Work
Oct 20, 2025
b4292b9
Optimize Resolver private mutations handling
Oct 23, 2025
bda5049
Revert to 64d056f
Oct 23, 2025
505e0cb
revert previous change
Oct 23, 2025
53713c2
Revert "revert previous change"
Oct 23, 2025
847cd99
Respond to review comments
Oct 27, 2025
90d2222
Respond to review comments.
Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions fdbserver/Resolver.actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,8 @@ ACTOR Future<Void> resolveBatch(Reference<Resolver> self,
}

if (SERVER_KNOBS->ENABLE_VERSION_VECTOR_TLOG_UNICAST) {
// Unicast requires resolver private mutations to be enabled.
ASSERT(useResolverPrivateMutations);
if (!self->numLogs) {
reply.tpcvMap.clear();
} else {
Expand Down