Convert `DataDistribution.actor.cpp` to standard coroutines by tclinkenbeard-oai · Pull Request #12799 · apple/foundationdb

tclinkenbeard-oai · 2026-03-18T04:35:12Z

This PR uses the same actor rewrite tool as other PRs to migrate DataDistribution.actor.cpp from Flow to standard C++.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

The PR has a description, explaining both the problem and the solution.
The description mentions which forms of testing were done and the testing seems reasonable.
Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

…coro

foundationdb-ci · 2026-03-18T04:56:50Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: c62d568
Duration 0:21:29
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-03-18T04:58:08Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: c62d568
Duration 0:22:43
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-03-18T04:58:53Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: c62d568
Duration 0:23:32
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2026-03-18T05:02:05Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: c62d568
Duration 0:26:41
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-03-18T05:02:36Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: c62d568
Duration 0:27:15
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-03-18T05:09:10Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: 86eafa6
Duration 0:25:56
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-03-18T05:23:02Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 86eafa6
Duration 0:39:47
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-03-18T05:35:58Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: 86eafa6
Duration 0:52:46
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-03-18T05:50:48Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: 86eafa6
Duration 1:07:35
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-03-18T06:41:14Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: 86eafa6
Duration 1:58:03
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

gxglass

Minor comments inline

gxglass · 2026-03-19T23:08:10Z

fdbserver/datadistributor/DataDistribution.cpp

 			ASSERT(!serverList.more && serverList.size() < CLIENT_KNOBS->TOO_MANY);

-			state int i;
+			int i{ 0 };
 			for (i = 0; i < serverList.size(); i++) {


for (int i = 0; ...)

gxglass · 2026-03-19T23:21:22Z

fdbserver/DataDistribution.cpp

-			state int i = 0;
+			RangeResult res =
+			    co_await krmGetRanges(&tr, bulkLoadTaskPrefix, KeyRangeRef(beginKey, jobState.getJobRange().end));
+			int i = 0;


for (int i = 0; ...)

gxglass · 2026-03-19T23:23:38Z

fdbserver/DataDistribution.cpp

+	RangeResult bulkLoadTaskResult;
+	KeyRange jobCompleteRange;
+	bool hasError = false;
+	int i = 0;


this outlives the loop it's being used in (apparently by design) so might deserve a longer name. maybe a TODO comment

foundationdb-ci · 2026-03-20T00:24:56Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 743dcd7
Duration 0:04:37
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-03-20T00:25:15Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: 743dcd7
Duration 0:04:54
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-03-20T00:25:50Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: 743dcd7
Duration 0:05:23
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-03-20T00:25:50Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: 743dcd7
Duration 0:05:27
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-03-20T00:26:05Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: 743dcd7
Duration 0:05:43
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2026-03-20T00:54:13Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: 0ada960
Duration 0:24:55
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-03-20T01:13:15Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 0ada960
Duration 0:43:58
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-03-20T01:19:28Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: 0ada960
Duration 0:50:12
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-03-20T01:28:12Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: 0ada960
Duration 0:58:53
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-03-20T02:37:40Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: 0ada960
Duration 2:08:20
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2026-03-20T02:49:14Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: b3fbe21
Duration 0:10:40
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-03-20T02:50:32Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: b3fbe21
Duration 0:11:56
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-03-20T03:02:18Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: b3fbe21
Duration 0:23:42
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

tclinkenbeard-oai added 10 commits March 18, 2026 03:29

Convert DataDistribution.actor.cpp to standard coroutines

487344a

Remove unnecessary braces

d08e445

Remove unnecessary co_return statements

a15d59b

Remove more unnecessary braces

0d31248

Remove unnecessary hasErr flags

d208860

Clean up race usage

5ad8ad4

Rename DataDistribution.actor.cpp

74783dc

Add comment to dataDistributor_impl

4fc183e

Merge remote-tracking branch 'origin/main' into dev/tclinkenbeard/dd-…

c62d568

…coro

Convert unit test to standard coroutine

86eafa6

tclinkenbeard-oai mentioned this pull request Mar 19, 2026

Explicitly invalidate stale tlog peek cursors #12812

Open

5 tasks

gxglass approved these changes Mar 19, 2026

View reviewed changes

tclinkenbeard-oai added 3 commits March 19, 2026 23:48

Merge remote-tracking branch 'apple/main' into dev/tclinkenbeard/dd-coro

d50b993

Fix build post-merge

aa38f03

Address review comments

743dcd7

Fix formatting

0ada960

Remove unnecessary store calls

b3fbe21

Conversation

tclinkenbeard-oai commented Mar 18, 2026

Code-Reviewer Section

For Release-Branches

Uh oh!

foundationdb-ci commented Mar 18, 2026

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 18, 2026

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Uh oh!

foundationdb-ci commented Mar 18, 2026

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Uh oh!

foundationdb-ci commented Mar 18, 2026

Result of foundationdb-pr on Linux RHEL 9

Uh oh!

foundationdb-ci commented Mar 18, 2026

Result of foundationdb-pr-clang on Linux RHEL 9

Uh oh!

foundationdb-ci commented Mar 18, 2026

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Uh oh!

foundationdb-ci commented Mar 18, 2026

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 18, 2026

Result of foundationdb-pr-clang on Linux RHEL 9

Uh oh!

foundationdb-ci commented Mar 18, 2026

Result of foundationdb-pr on Linux RHEL 9

Uh oh!

foundationdb-ci commented Mar 18, 2026

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Uh oh!

gxglass left a comment

Choose a reason for hiding this comment

Uh oh!

gxglass Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

gxglass Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

gxglass Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

foundationdb-ci commented Mar 20, 2026

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 20, 2026

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Uh oh!

foundationdb-ci commented Mar 20, 2026

Result of foundationdb-pr on Linux RHEL 9

Uh oh!

foundationdb-ci commented Mar 20, 2026

Result of foundationdb-pr-clang on Linux RHEL 9

Uh oh!

foundationdb-ci commented Mar 20, 2026

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Uh oh!

foundationdb-ci commented Mar 20, 2026

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Uh oh!

foundationdb-ci commented Mar 20, 2026

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 20, 2026

Result of foundationdb-pr-clang on Linux RHEL 9

Uh oh!

foundationdb-ci commented Mar 20, 2026

Result of foundationdb-pr on Linux RHEL 9

Uh oh!

foundationdb-ci commented Mar 20, 2026

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Uh oh!

foundationdb-ci commented Mar 20, 2026

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Uh oh!