Make throttling on tlog disk space more gradual#12807
Open
tclinkenbeard-oai wants to merge 3 commits intoapple:mainfrom
Open
Make throttling on tlog disk space more gradual#12807tclinkenbeard-oai wants to merge 3 commits intoapple:mainfrom
tclinkenbeard-oai wants to merge 3 commits intoapple:mainfrom
Conversation
Contributor
Result of foundationdb-pr-clang-ide on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Contributor
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Contributor
Result of foundationdb-pr on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-clang on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
| init( TARGET_BYTES_PER_TLOG_BATCH, 1400e6 ); if( smallTlogTarget ) TARGET_BYTES_PER_TLOG_BATCH = 1400e3; | ||
| init( SPRING_BYTES_TLOG_BATCH, 300e6 ); if( smallTlogTarget ) SPRING_BYTES_TLOG_BATCH = 150e3; | ||
| // Match MIN_AVAILABLE_SPACE by default; buggified simulations exercise the earlier ramp. | ||
| init( TLOG_THROTTLE_START_AVAILABLE_SPACE_RATIO, 0.05 ); if( randomize && isSimulated && BUGGIFY ) TLOG_THROTTLE_START_AVAILABLE_SPACE_RATIO = 0.20; |
There was a problem hiding this comment.
Do we want to have START and STOP as configurable params?
Collaborator
Author
There was a problem hiding this comment.
STOP is effectively MIN_AVAILABLE_SPACE_RATIO, there isn't a separate knob for this yet, but I don't think we need one
Contributor
|
@tclinkenbeard-oai I'll have a look. I haven't looked at any of this stuff before so need a little time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if a tlog runs out of disk space, throttling ramps up extremely quickly once
MIN_AVAILABLE_SPACE_RATIOis reached. This PR introduces a newTLOG_THROTTLE_START_AVAILABLE_SPACE_RATIOknob that supports more gradual throttling.By default the knob has no effect, but if set to e.g. 0.2 (with
MIN_AVAILABLE_SPACE_RATIOat the default 0.05), the target tlog queue size (used for the ratekeeper'stpsLimitcalculation) scales linearly downward as available space decreases from 20% to 5%.Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormainif this is the youngest branch)