Backport overall status timeout budget to release-7.4#13760
Open
hxu wants to merge 2 commits into
Open
Conversation
(cherry picked from commit 79de020)
Propagate the overall status deadline through the client coordinator probe and add coverage for the client phase.
hxu
marked this pull request as ready for review
July 21, 2026 06:49
This was referenced Jul 21, 2026
Contributor
Result of foundationdb-pr-macos-m1 on macOS 14.x
|
Contributor
Result of foundationdb-pr-clang on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-clang-arm on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-macos on macOS 14.x
|
Contributor
Result of foundationdb-pr on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports the original overall-budget commit and the client-phase correction and tests from #13759 to
release-7.4. It is the release-7.4 counterpart to the release-7.3 backport, #13749.The original change gave controller discovery and the cluster status RPC one shared deadline, but the earlier client-side coordinator quorum probe retained its fixed two-second timeout. That gap allowed
STATUS_TIMEOUT=0.2to take two seconds during a coordinator outage. This backport carries the deadline through all three phases and includes separate regression coverage for the client probe and cluster RPC budget.release-7.4still uses actor-basedStatusClient.actor.cppand supports filtered status requests, so the semantic cherry-pick keeps the actor state andstatusFieldAPI while preserving the original author and source-commit metadata.Summary of PRs:
Then:
Testing:
fdbserverbuild: passedfdbserver -r unittests -f /fdbclient/status/: 2 passedCode-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
release-branchormainif this is the youngest branch)