Skip to content

Conversation

@vcsjones
Copy link
Contributor

Overall Checklist

for password-rules.json

  • The given rule isn't particularly standard and obvious for password managers
  • Generated passwords have been tested from this rule using the Password Rules Validation Tool
  • Information has been included about the website's requirements (eg. screenshots, error messages, steps during experimentation, etc.)
  • The PR isn't documenting something that would be a common practice among password managers (e.g. minimal length of 6)
Collapsing unrelated checklist

for change-password-URLs.json

  • There is no Well-Known URL for Changing Passwords (https://example.com/.well-known/change-password)
  • The URL either makes the experience better or no worse than being directed to just the domain in a non-logged-in state

for shared-credentials.json

  • There's evidence the domains are currently related (SSL certificates, DNS entries, valid links between sites, legal documents etc.)
  • If using shared, the new group serves login pages on each of the included domains, and those login pages accept accounts from the others. (For example, we wouldn't use a shared association from google.co.il to google.com, because google.co.il redirects to accounts.google.com for sign in.)
  • If using from and to, the new group, the from domain(s) redirect to the to domain to log in.

for shared-credentials-historical.json

  • You believe that the domains were associated at some point in the past and can explain that relationship

The patient portal for clarksoneyecare.com requires special characters, but of the permitted special characters, a hyphen (-) is not permitted. This results in Apple's default generated passwords not meeting the password requirements.

Here is a screenshot of the password rules:

Screenshot 2024-05-31 at 3 18 13 PM

Lowercase letters are required too, but since the website only shows you the rules on validation, I had to put something in the textbox to tell me what the requirements were, which I used a single letter "a" for that. That is why required: lower is included though the error message does not indicate it is required.

The website also (seemingly) has no maximum password length, so that was omitted.

vcsjones and others added 2 commits May 31, 2024 15:41
In the password requirements for this website it is not explicitly stated that lower case characters are required, but they are allowed.
@dmmaslenn
Copy link
Collaborator

I've updated this PR since in the password requirements for this website it is not explicitly stated that lower case characters are required, but they are allowed.
@vcsjones please let us know if we missed something and lowercase characters need to be required.

@dmmaslenn dmmaslenn requested review from dmmaslenn and removed request for dmmaslenn September 27, 2024 22:23
@dmmaslenn dmmaslenn merged commit f0bd963 into apple:main Sep 27, 2024
5 checks passed
rmondello pushed a commit to rmondello/password-manager-resources that referenced this pull request Nov 6, 2024
* Add rules for clarksoneyecare.com

* Fixed lower case characters to be allowed instead of required

In the password requirements for this website it is not explicitly stated that lower case characters are required, but they are allowed.

---------

Co-authored-by: Daria Maslennikova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants