Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared-credentials: Add auth.wikimedia.org to Wikimedia set #868

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

Krinkle
Copy link
Contributor

@Krinkle Krinkle commented Jan 30, 2025

Overall Checklist

for shared-credentials.json

  • There's evidence the domains are currently related (SSL certificates, DNS entries, valid links between sites, legal documents etc.)
  • If using shared, the new group serves login pages on each of the included domains, and those login pages accept accounts from the others. (For example, we wouldn't use a shared association from google.co.il to google.com, because google.co.il redirects to accounts.google.com for sign in.)

Hi,

I'm an engineer on the MediaWiki Engineering team at Wikimedia Foundation. Over the next few months, we'll be moving logins from being local to each of ~900 wikis over ~10 top-level domains (with credentials shared behind the scenes) to instead happen centrally on the new auth.wikimedia.org domain.

This can be tested today on https://test.wikipedia.org/ where "Log in" directs you to https://auth.wikimedia.org/testwiki/wiki/Special:UserLogin. Compare this to the status quo on domains like en.wikipedia.org, wikidata.org, and ja.wikivoyage.org where login happens on the same domain.

Issue tracker: https://phabricator.wikimedia.org/T384844

@rmondello
Copy link
Contributor

Hi @Krinkle! Thank you for this thoughtful contribution with lots of cited supporting evidence. Accommodating a change ahead of time isn’t something we’ve done before, but I’m more than happy to do it in this case.

@rmondello rmondello merged commit 9917b5c into apple:main Jan 30, 2025
5 checks passed
@Krinkle Krinkle deleted the patch-1 branch January 30, 2025 15:16
@Krinkle
Copy link
Contributor Author

Krinkle commented Jan 30, 2025

@rmondello Thanks. Yeah, it's an atypical addition because it's not really adding a new site (i.e. a site with its own user signup and where community overlap to other sites might be minimal at first, so non-urgent). Anyone who's ever saved a password for Wikipedia will lose auto-fill unless the new domain is associated with previous domains.

@rmondello
Copy link
Contributor

@Krinkle Atypical, but valuable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants