Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add candyrect.com and nekochat.cn #877

Merged
merged 4 commits into from
Mar 10, 2025
Merged

Add candyrect.com and nekochat.cn #877

merged 4 commits into from
Mar 10, 2025

Conversation

rdp-studio
Copy link
Contributor

Overall Checklist

for password-rules.json

  • The given rule isn't particularly standard and obvious for password managers
  • Generated passwords have been tested from this rule using the Password Rules Validation Tool
  • Information has been included about the website's requirements (eg. screenshots, error messages, steps during experimentation, etc.)
  • The PR isn't documenting something that would be a common practice among password managers (e.g. minimal length of 6)

for change-password-URLs.json

  • There is no Well-Known URL for Changing Passwords (https://example.com/.well-known/change-password)
  • The URL either makes the experience better or no worse than being directed to just the domain in a non-logged-in state

for shared-credentials.json

  • There's evidence the domains are currently related (SSL certificates, DNS entries, valid links between sites, legal documents etc.)
  • If using shared, the new group serves login pages on each of the included domains, and those login pages accept accounts from the others. (For example, we wouldn't use a shared association from google.co.il to google.com, because google.co.il redirects to accounts.google.com for sign in.)
  • If using from and to, the new group, the from domain(s) redirect to the to domain to log in.

Access to https://user.nekochat.cn will redirect to https://user.candyrect.com

for shared-credentials-historical.json

  • You believe that the domains were associated at some point in the past and can explain that relationship

@rmondello
Copy link
Contributor

Run ruby .github/workflows/lint-scripts/websites-shared-credentials-sort-order.rb
The JSON in 'quirks/shared-credentials.json' isn't sorted!
Error: Process completed with exit code 1.

@rmondello
Copy link
Contributor

@rdp-studio If you could, please sort the new entry in the shared credentials file by the first item in the array. So it should be higher up.

@rmondello rmondello merged commit 3cbb150 into apple:main Mar 10, 2025
5 checks passed
@rmondello
Copy link
Contributor

Thanks @rdp-studio!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants