Update change-password-URLs.json to include singapore air #939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added singapore airlines change password url
rmondello
requested changes
Jul 30, 2025
quirks/change-password-URLs.json
Outdated
| "shoop.de": "https://www.shoop.de/einstellungen/benutzerdaten", | ||
| "shopback.co.kr": "https://www.shopback.co.kr/account/change-password", | ||
| "shutterfly.com": "https://www.shutterfly.com/account-settings/", | ||
| "singaporeair.com":"https://www.singaporeair.com/kfResetPIN-flow.form", |
There was a problem hiding this comment.
Can you add a space so the style of this line matches all of the others?
There was a problem hiding this comment.
edited and updated. Thanks @rmondello !
Added additional space between key value for singaporeair
rmondello
reviewed
Jul 30, 2025
quirks/change-password-URLs.json
Outdated
| "shoop.de": "https://www.shoop.de/einstellungen/benutzerdaten", | ||
| "shopback.co.kr": "https://www.shopback.co.kr/account/change-password", | ||
| "shutterfly.com": "https://www.shutterfly.com/account-settings/", | ||
| "singaporeair.com": "https://www.singaporeair.com/kfResetPIN-flow.form", |
There was a problem hiding this comment.
Is this a “change password” page or a “reset password” page? If it’s a “reset password” page, is there a change password page, or does this website only allow changing via reset?
There was a problem hiding this comment.
Ah okay. You are right, they do have a different change password page. Will edit my PR accordingly. Sorry for the confusion :')
There was a problem hiding this comment.
Updated again @rmondello. Hopefully this time I didn't miss anything.
Edited from reset password to change password url. My bad on the oversight.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added singapore airlines change password url
Overall Checklist
for change-password-URLs.json
https://example.com/.well-known/change-password)