Id dot nfpa dot org #950
Merged
Id dot nfpa dot org #950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move caret so it doesn't need to be escaped
rmondello
reviewed
Sep 2, 2025
quirks/password-rules.json
Outdated
| "password-rules": "minlength: 8; maxlength: 20; required: lower; required: upper; required: digit;" | ||
| }, | ||
| "id.nfpa.org": { | ||
| "password-rules": "minlength: 8; maxlength: 16; required: lower; required: upper; required: digit; required: [\"^#$%&'()*+:=@[_|{}~]];" |
There was a problem hiding this comment.
Can we add - to this character class? So: [-\"^#$%&'()*+:=@[_|{}~]]
There was a problem hiding this comment.
Thank you for catching that!
There was a problem hiding this comment.
Thank you for the great contributions!
Somehow this got lost in the shuffle
rmondello
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Checklist
for password-rules.json
Per request in #858. If this website would just allow 20 character passwords then none of this would have been necessary.