Fix NPE in VmTyped.hashCode when property is null#1320
Open
jurajmaj wants to merge 2 commits intoapple:mainfrom
Open
Fix NPE in VmTyped.hashCode when property is null#1320jurajmaj wants to merge 2 commits intoapple:mainfrom
jurajmaj wants to merge 2 commits intoapple:mainfrom
Conversation
Author
Contributor
|
Hi @jurajmaj, thanks for the contribution! Most of the team is away until December, so it'll take us a little more time to review this fully. Thanks for your patience! That said, my gut feeling here is that isn't quite the right way to resolve this. The cached property value being |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1167
Null properties in
VmTypedpreviously caused a NPE when accessed throughhashCode().This fix adds null checks so that
containsKeyand other map operations do not crash.