Open
Conversation
HT154
reviewed
Jan 7, 2026
pkl-core/src/main/java/org/pkl/core/evaluatorSettings/PklEvaluatorSettings.java
Outdated
Show resolved
Hide resolved
This introduces breaking changes for external readers are loaded: 1. In PklProject, relative paths are resolved relative to the enclosing PklProject file (make behavior consistent with how other settings work) 2. Prevent external readers from being set for non-file based PklProject 3. Make CLI flags blow away any settings set on a PklProject The overall goal is to make this behavior consistent with how other settings work. For example, relative paths for other evaluator settings are already relative to the project directory. Additionally, in every other case, CLI flags will overwrite any setting set within PklProject.
bioball
force-pushed
the
external-reader-loading
branch
from
2ada6e5 to
09218e7
Compare
HT154
reviewed
Jan 10, 2026
stdlib/EvaluatorSettings.pkl
Outdated
Comment on lines
123
to
125
HT154
reviewed
Jan 10, 2026
stdlib/Project.pkl
Outdated
Contributor
There was a problem hiding this comment.
Suggested change
| /// Machiney for URI percent decoding. | |
| /// Machinery for URI percent decoding. |
HT154
approved these changes
Jan 13, 2026
Contributor
HT154
left a comment
HT154
left a comment
There was a problem hiding this comment.
LGTM modulo the above comments, approving to unblock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces breaking changes for external readers are loaded:
The overall goal is to make this behavior consistent with how other settings work.
For example, relative paths for other evaluator settings are already relative to the project directory.
Additionally, in every other case, CLI flags will overwrite any setting set within PklProject.
[windows]