Added pkg module key factory and resource reader to project loading#1547
Open
netvl wants to merge 1 commit intoapple:mainfrom
Open
Added pkg module key factory and resource reader to project loading#1547netvl wants to merge 1 commit intoapple:mainfrom
pkg module key factory and resource reader to project loading#1547netvl wants to merge 1 commit intoapple:mainfrom
Conversation
This change allows `PklProject` files, usually loaded via the `Project` static methods, to have references to external packages via `package://` URIs. This is helpful for centralizing and sharing common package configuration via packages.
Contributor
In case it helps, pkl-commons-test has |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows
PklProjectfiles, usually loaded via theProjectstatic methods, to have references to external packages viapackage://URIs.This is helpful for centralizing and sharing common package configuration via packages.
I don't think there is an infrastructure in tests to test
package:URIs since they require HTTP calls, and this PR doesn't seem like a good place to add it, but if you think it would make sense to do it, I can try to come up with something.