Fix CRLF handling in line continuation escapes#1564
Merged
Conversation
This is only really an issue if you're using Windows, or save a file using CRLF line endings. Also fix the "whitespace before continuation" error to detect `\r` as a newline. ## Example programs ```pkl x = """ hello \ world """ y = #""" hello \# world """# ```
KushalP
commented
Apr 29, 2026
| assertThat(lexer.next()).isEqualTo(Token.ASSIGN) | ||
| assertThat(lexer.next()).isEqualTo(Token.STRING_MULTI_START) // """ | ||
| assertThat(lexer.next()).isEqualTo(Token.STRING_NEWLINE) | ||
| assertThat(lexer.next()).isEqualTo(Token.STRING_PART) // " hello " |
Contributor
Author
There was a problem hiding this comment.
I'm happy to remove all of these comments. I annotated the tests like this for my own sanity to figure this out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is only really an issue if you're using Windows, or save a file using CRLF line endings.
Also fix the "whitespace before continuation" error to detect
\ras a newline.Example programs