Improve error for amendments without defaults - #1841
Open
henriquejsza wants to merge 1 commit into
Open
Conversation
Report the missing default value only when an object body is trying to amend an implicitly defaulted property. Preserve undefined-value errors from explicit property bodies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
prop { ... }tries to amend a property whose declared type has no default value, report:This is limited to object-body amendments. Regular reads and undefined values from explicit property bodies keep their existing errors.
Adds snippet coverage for object and class property amendments, including a union whose selected member has no default value.
Fixes #1368