Added visible string implementation with tests - #113
Merged
Conversation
Lukasa
reviewed
Feb 23, 2026
Lukasa
left a comment
Lukasa
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this! This is mostly really good, can we add some tests that fail validation just to confirm we reject invalid strings?
…sibleString to String
Contributor
Author
|
Oh, great catch! I missed those negative tests. I filled in the gaps. Again, inspired by printable string. Check again please. |
Lukasa
reviewed
Feb 24, 2026
| let validBytes = allBytes.filter { !invalidBytes.contains($0) } | ||
|
|
||
| for byte in invalidBytes { | ||
| print(byte) |
Lukasa
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added missing ASN1 type (ASN1VisibleString) with tests. Implementations is heavily inspired by existing implementation of ASN1PrintableString. Differs only in validation rules (_isValid method) and encoding identifier (defaultIdentifier property).