Skip to content

Add env flag to accept swift-crypto beta releases #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lukasa merged 2 commits into from
Jul 1, 2026
Merged

Add env flag to accept swift-crypto beta releases #302

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5b686d
Widen swift-crypto dependency bounds through env flag
josephnoir Jun 26, 2026
9d1b8c6
Merge branch 'main' into crypto-beta-env
josephnoir Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,25 @@ let package = Package(
// we're building in the Swift.org CI system alongside other projects in the Swift toolchain and
// we can depend on local versions of our dependencies instead of fetching them remotely.
if ProcessInfo.processInfo.environment["SWIFTCI_USE_LOCAL_DEPS"] == nil {

// If the `SWIFT_CERTIFICATES_ALLOW_SWIFT_CRYPTO_BETA` environment variable is set
// swift-certificates will accept swift-crypto beta releases as a dependency.
//
// Note: A beta release can only be used if other packages in the dependency tree
// that have a direct dependency on swift-crypto accept beta releases as well.
if ProcessInfo.processInfo.environment["SWIFT_CERTIFICATES_ALLOW_SWIFT_CRYPTO_BETA"] == nil {

@Lukasa Lukasa Jun 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentionally nested?

@josephnoir josephnoir Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the intention was for local dependencies to have precedence. Flipping the comparisons could make this an else if branch.

if ProcessInfo.processInfo.environment["SWIFTCI_USE_LOCAL_DEPS"] != nil {
  // use local repos
} else if ProcessInfo.processInfo.environment["SWIFT_CERTIFICATES_ALLOW_SWIFT_CRYPTO_BETA"] != nil {
  // accept swift-crypto beta releases
} else {
  // default dependency range
}

@Lukasa Lukasa Jul 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh gotcha, I see.

package.dependencies += [
.package(url: "https://github.com/apple/swift-crypto.git", "3.12.3"..<"5.0.0")
]
} else {
print("Accepting beta versions of swift-crypto!")
package.dependencies += [
.package(url: "https://github.com/apple/swift-crypto.git", "3.12.3"..<"5.0.0-beta.max")
]
}

package.dependencies += [
.package(url: "https://github.com/apple/swift-crypto.git", "3.12.3"..<"5.0.0"),
.package(url: "https://github.com/apple/swift-asn1.git", from: "1.1.0"),
.package(url: "https://github.com/apple/swift-asn1.git", from: "1.1.0")
]
} else {
package.dependencies += [
Expand Down
Loading