CMS.isValidAttachedSignature() not using additionalIntermediateCertificates arg - #308
Open
ericb-apple wants to merge 1 commit into
Open
Conversation
…icates arg Motivation: CMS.isValidAttachedSignature() accepts additionalIntermediateCertificates[] but doesn't pass it along to .isValidSignature(), causing verification of messages with an attached signature to fail if it contains intermediate cert(s). Modifications: * Pass additionalIntermediateCertificates[] arg in CMS.isValidAttachedSignature() onto .isValidSignature() * Added CMSTests.testCanProvideIntermediatesDuringAttachedVerification() test case (demonstrating the fix) Result: CMS messages with attached signatures containing intermediate certs will now pass verification via CMS.isValidAttachedSignature()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
CMS.isValidAttachedSignature()acceptsadditionalIntermediateCertificates[]but doesn't pass it along to.isValidSignature(), causing verification of messages with an attached signature to fail if it contains intermediate cert(s).Modifications:
additionalIntermediateCertificates[]arg inCMS.isValidAttachedSignature()onto.isValidSignature()CMSTests.testCanProvideIntermediatesDuringAttachedVerification()test case (demonstrating the fix)Result:
CMS messages with attached signatures containing intermediate certs will now pass verification via
CMS.isValidAttachedSignature()