Skip to content

Modernize this code base #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 22, 2025
Merged

Modernize this code base #24

merged 14 commits into from
May 22, 2025

Conversation

lorentey
Copy link
Member

  • Bump required toolchain version to Swift 6.1.
  • Bump minimum deployment target to macOS 15, iOS 18, watchOS 11, tvOS 18, visionOS 2.
  • Fix some glaring issues with concurrency safety; add Sendable where required.
  • Adopt the use of SuspendingClock and Duration from the Swift Standard Library for measuring elapsed time.
  • Use struct Atomic from the stdlib to do basic synchronization.
  • Update dependencies to their latest versions.
  • Stop supporting a built-in charts library -- the library json now always needs to be explicitly specified on the command line.

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering my changes (if appropriate).
  • I've verified that my change compiles and works correctly, and does not break any existing tests.
  • I've updated the documentation (if appropriate).

@lorentey
Copy link
Member Author

@swift-ci test

@lorentey
Copy link
Member Author

Run which yamllint || (apt -q update && apt install -yq yamllint)
/opt/pipx_bin/yamllint
Downloading default yamllint config file
./.spi.yml
  Error: 4:52 [new-line-at-end-of-file] no new line character at the end of file

😠

@lorentey
Copy link
Member Author

  Error: 5:1 [empty-lines] too many blank lines (1 > 0)

Oh come on! Cc @shahmishal

@lorentey
Copy link
Member Author

@swift-ci test

@lorentey
Copy link
Member Author

@swift-ci test

@lorentey lorentey merged commit 69cd5b4 into apple:main May 22, 2025
18 checks passed
@lorentey lorentey deleted the modernization branch May 22, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant