Skip to content

Fix example manifest in README.md making target executable #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

valeriyvan
Copy link

@valeriyvan valeriyvan commented May 26, 2025

Make .target as .executableTarget in sample manifest in README.
Without this change it's impossible to run benchmark because there's build error:

error: '########': executable product 'benchmark' expects target 'benchmark' to be executable; an executable target requires a 'main.swift' file

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering my changes (if appropriate).
  • I've verified that my change compiles and works correctly, and does not break any existing tests.
  • I've updated the documentation (if appropriate).

@valeriyvan valeriyvan requested a review from lorentey as a code owner May 26, 2025 19:17
Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@lorentey
Copy link
Member

@swift-ci test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants