Fix hang using multi-node package plugin on Swift 6+ #1208
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The integration tests for Swift 6.0 and 6.1 are hanging. They are passing on Swift 5.10. This is because SwiftPM started taking a lock over the package and cannot be run concurrently on the same package.
This is causing hangs in the integration test because it calls the
multi-node
package plugin which is running theMultiNodeTestKitRunner
usingswift run MultiNodeTestKitRunner
.This isn't the supported way for Swift package plugins to use executables from the package, which should instead be looked up from the context passed into the plugin.
Modifications:
Use the package plugin context to find the executable dependency used by the multi-node plugin.
Result:
Integration tests no longer hang on Swift 6.0 and 6.1.