Decouple Context and Scheme and make HeScheme context flexible #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fboemer
force-pushed
the
fboemer/flexible-context-for-he-scheme
branch
from
8049bc9 to
6b0799a
Compare
fboemer
force-pushed
the
fboemer/flexible-context-for-he-scheme
branch
2 times, most recently
from
657227d to
5a71a0a
Compare
fboemer
force-pushed
the
fboemer/flexible-context-for-he-scheme
branch
from
5a71a0a to
28c8e83
Compare
fboemer
changed the title
fboemer
changed the title
fboemer
commented
May 2, 2025
| @@ -24,7 +24,7 @@ import HomomorphicEncryption | |||
| let encryptParams = | |||
| try EncryptionParameters<UInt64>(from: .insecure_n_8_logq_5x18_logt_5) | |||
| // Perform pre-computation for HE computation with these parameters. | |||
| let context = try Context<Bfv<UInt64>>(encryptionParameters: encryptParams) | |||
| let context = try Bfv<UInt64>.Context(encryptionParameters: encryptParams) | |||
There was a problem hiding this comment.
Alternatively, we could prefer this API:
Suggested change
| let context = try Bfv<UInt64>.Context(encryptionParameters: encryptParams) | |
| let context = try Context<UInt64>(encryptionParameters: encryptParams) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes, which both affect
Context, so I figure it's easier to review as one change.