Disable Swift Configuration Traits - #184
Open
0xTim wants to merge 1 commit into
Open
Conversation
fabianfett
reviewed
Aug 11, 2026
| .package(url: "https://github.com/apple/swift-nio-extras.git", from: "1.34.1"), | ||
| .package(url: "https://github.com/apple/swift-nio-http2.git", from: "1.44.0"), | ||
| .package(url: "https://github.com/apple/swift-configuration.git", from: "1.2.0"), | ||
| .package(url: "https://github.com/apple/swift-configuration.git", from: "1.2.0", traits: []), |
Member
There was a problem hiding this comment.
we should likely have a test case (/ci job), that validates that we don't link full Foundation when default traits are being used.
guoye-zhang
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Swift Configuration's default traits pull in full Foundation because they enable the JSON configuration provider, which uses JSONSerialization. That undoes all the hard work in the library to only use FoundationEssentials as full foundation will be linked anyway. Since the HTTP APIs doesn't need any of the trait-hidden code, let's not include them.
Related to swift-server/swift-http-server#109
Modifications
Don't link full Foundation
Result
Downstream packages won't be forced to include the full Foundation
Test Plan
Compilation is enough