Do not create an encoder stream if dynamic table is not used - #12
Merged
Conversation
josephnoir
requested changes
Jul 10, 2026
josephnoir
approved these changes
Jul 13, 2026
glbrntt
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When the connection is started a client is offering a Dynamic Table with the size of 4096:
And so the HTTP server opens encoder streams even though it doesnt look like the Dynamic table is supported:
So each packet from the peer contains a client QPACK decoder frame:
(Each packet has a QPACK Decoder frame in it)
19 0.983563 HTTP3 1486 QPACK DEC[1], STREAM(12), HEADERS: GET https://192.168.xxx.xxx:8080/responsiveness/download/1000, PADDING
23 0.984147 HTTP3 1486 QPACK DEC[1], STREAM(20), HEADERS: GET https://192.168.xxx.xxx:8080/responsiveness/download/1000, PADDING
And this causes QUIC and HTTP3 to use a lot of CPU processing the decoder frame.
Modifications
Setup a effectiveDynamicTableSize to be based on the local and remote table size, if one is zero then the encoder stream will not be opened.
Result
Nice reduction in CPU.
Top of tree without this change:
With this change: