Bump to swift-nio-quic 0.2.1 - #15
Merged
Merged
Conversation
Motivation: swift-nio-quic tagged a new release with some breaking changes Modifications: - Adopt new API Result: Builds
aryan-25
approved these changes
Jul 30, 2026
Contributor
Author
|
@aryan-25 FYI I have some fixes to swift-nio-quic in flight as well: the CI broke a while ago so we've accrued a few regressions. |
Motivation:
When the peer closes the connection, SwiftNetwork delivers the
CONNECTION_CLOSE to every stream flow, so each stream's pipeline sees a
'QUICConnectionError' before the connection's pipeline does. The
coordinator's own fan-out ('cancelStreamsDueToConnectionClose') can't
reach those streams because they have already closed and deregistered by
the time it runs.
'HTTP3StreamHandler' passed the error through untouched, so the owner of
a request stream saw a QUIC error rather than an HTTP/3 one. It already
translates the other two peer-close errors, RESET_STREAM and
STOP_SENDING; CONNECTION_CLOSE was the missing third.
Modifications:
- Translate 'QUICConnectionError' into an 'HTTP3Error' with code
'remoteConnectionError' in 'HTTP3StreamHandler.errorCaught', keeping
the peer's reason phrase and, for application errors, its error code.
Result:
Streams report HTTP/3 errors when the connection is closed by the peer
glbrntt
commented
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
swift-nio-quic tagged a new release with some breaking changes
Modifications:
self.contextis nil in release queue; this can be reached re-entrantly when a peer attempts to open an invalid stream. This was previously not reachable because of incorrect behavior in swift-nio-quic.Result:
Builds and tests pass