Skip to content

Remove maximumTokenLength argument in test helper #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aryan-25 merged 1 commit into from
Jun 18, 2026
Merged

Remove maximumTokenLength argument in test helper #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Tests/H3IntegrationTests/EndToEndTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1548,7 +1548,6 @@ struct EndToEndTests {
configuration: config,
settings: settings,
quicConfiguration: quicConfiguration,
maximumTokenLength: 100,
logger: logger,
internalInboundStreamInitializer: internalInboundStreamInitializer
)
Expand Down
9 changes: 0 additions & 9 deletions Tests/H3IntegrationTests/HTTP3+NIOQUIC.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ extension ChannelPipeline.SynchronousOperations {
/// - configuration: The ``HTTP3ServerConfiguration``.
/// - settings: The `HTTP3Settings` to use for all incoming connections.
/// - quicConfiguration: The `QUICConfiguration` to be used.
/// - maximumTokenLength: The maximum length of tokens.
/// - metrics: The metrics.
/// - logger: The logger.
/// - inboundRequestStreamInitializer: Closure to run for each incoming stream. Must be synchronous.
Expand All @@ -47,7 +46,6 @@ extension ChannelPipeline.SynchronousOperations {
configuration: HTTP3ServerConfiguration = .defaults,
settings: HTTP3Settings = .init(),
quicConfiguration: QUICConfiguration,
maximumTokenLength: Int = 0,
metrics: QUICMetrics? = nil,
logger: Logger,
inboundRequestStreamInitializer:
Expand All @@ -67,7 +65,6 @@ extension ChannelPipeline.SynchronousOperations {
let quicHandler = QUICHandler(
channel: channel,
quicConfiguration: quicConfiguration,
maximumTokenLength: maximumTokenLength,
asyncVerifier: nil,
authenticator: authenticator,
logger: logger,
Expand Down Expand Up @@ -116,7 +113,6 @@ extension ChannelPipeline.SynchronousOperations {
/// - configuration: The ``HTTP3ClientConfiguration``.
/// - settings: The `HTTP3Settings` to use for all outgoing connections.
/// - quicConfiguration: The `QUICConfiguration` to be used.
/// - maximumTokenLength: The maximum length of tokens.
/// - metrics: The metrics.
/// - logger: The logger.
/// - internalInboundStreamInitializer: A closure which will be called for every incoming non-push stream.
Expand All @@ -127,7 +123,6 @@ extension ChannelPipeline.SynchronousOperations {
configuration: HTTP3ClientConfiguration = .defaults,
settings: HTTP3Settings = .init(),
quicConfiguration: QUICConfiguration,
maximumTokenLength: Int = 0,
metrics: QUICMetrics? = nil,
logger: Logger,
internalInboundStreamInitializer: (
Expand All @@ -149,7 +144,6 @@ extension ChannelPipeline.SynchronousOperations {
let quicHandler = QUICHandler(
channel: channel,
quicConfiguration: quicConfiguration,
maximumTokenLength: maximumTokenLength,
asyncVerifier: asyncVerifier,
authenticator: nil,
logger: logger,
Expand Down Expand Up @@ -215,7 +209,6 @@ extension ChannelPipeline.SynchronousOperations {
/// - configuration: The ``HTTP3ServerConfiguration``.
/// - settings: The `HTTP3Settings` to use for all incoming connections.
/// - quicConfiguration: The `QUICConfiguration` to be used.
/// - maximumTokenLength: The maximum length of tokens.
/// - metrics: The metrics.
/// - logger: The logger.
/// - inboundConnectionInitializer: Closure to run for each incoming connection.
Expand All @@ -227,7 +220,6 @@ extension ChannelPipeline.SynchronousOperations {
configuration: HTTP3ServerConfiguration = .defaults,
settings: HTTP3Settings = .init(),
quicConfiguration: QUICConfiguration,
maximumTokenLength: Int = 0,
metrics: QUICMetrics? = nil,
logger: Logger,
inboundConnectionInitializer: @Sendable @escaping (any Channel) -> EventLoopFuture<Void>,
Expand All @@ -251,7 +243,6 @@ extension ChannelPipeline.SynchronousOperations {
let quicHandler = QUICHandler(
channel: channel,
quicConfiguration: quicConfiguration,
maximumTokenLength: maximumTokenLength,
asyncVerifier: nil,
authenticator: authenticator,
logger: logger,
Expand Down
Loading