Remove platform requirements - #4
Merged
Merged
Conversation
aryan-25
marked this pull request as ready for review
June 22, 2026 19:53
gjcairo
approved these changes
Jun 24, 2026
|
I need this change! Thanks! Hope we can merge it soon... |
josephnoir
approved these changes
Jun 24, 2026
glbrntt
enabled auto-merge (squash)
June 30, 2026 09:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The 26.0 platform requirements are only present due to the
swift-nio-quicdependency. Moreover, this dependency is only required by theH3IntegrationTeststest target.Following from apple/swift-nio-quic#18, we can now transitively drop the platform requirements in this repo and gate declarations using
swift-nio-quicAPIs inH3IntegrationTestsbehind an@available(anyAppleOS 26, *)guard.Modifications
swift-nio-quicdependency to point to the branch of Drop platforms block and add availability annotations swift-nio-quic#18.platformdeclaration inPackage.swift.@available(anyAppleOS 26, *)guard to all declarations inH3IntegrationTestsusingswift-nio-quicAPIs.@available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *)guard to all declarations behind theHTTP3AsyncInterfaceSPI (to match the availability ofAsyncStreaming).Result
swift-nio-http3can be used without 26.0 platform requirements.