Speed up allocation counting tests #3197
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The allocation counting tests take around 23 minutes in CI, which is quite a while! The tests themselves don't take nearly so long, however each test is run 11 times but between each time the framework waits for allocations to become rebalanced (i.e. everything we allocated should be freed). The framework will wait up to 5 seconds between each iteration for this. About 15 or so tests take 55 seconds, meaning they're just waiting for the allocs to quiece. It turns out that dispatch doesn't always free blocks from
async
work items immediately. This is relevant because a number of tests create their own MTELGs, and so when they are shutdown we see allocations from the shutdown flow lingering for more than 5 seconds.Not only does this slow the tests down, if the allocations don't quiece, the framework ignores the result, so we lose some coverage too.
Modifiications:
swift run
and just execute the test binary, this shaves off a few seconds for each test.Result: