Skip to content

Add structured concurrency aware ServerBootstrap bind #3378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
+444 −60
Draft

Add structured concurrency aware ServerBootstrap bind #3378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
76c7590
Add structured concurrency aware ServerBootstrap bind
fabianfett Sep 22, 2025
70b0aa1
Undeprecate NIOAsyncChannel properties
fabianfett Sep 22, 2025
afa3d9d
Doc how to graceful shutdown
fabianfett Sep 22, 2025
8dbb961
Update NIOTCPEchoServer example
fabianfett Sep 22, 2025
227beb8
PR review: Use non throwing task group.
fabianfett Sep 22, 2025
21cd496
PR review
fabianfett Sep 22, 2025
c05579c
Add once startup closure
fabianfett Sep 23, 2025
378dca5
PR reviews
fabianfett Sep 25, 2025
1b3dde7
Use spi
fabianfett Sep 25, 2025
cf26162
PR review
fabianfett Sep 25, 2025
6b26145
Swift format
fabianfett Sep 25, 2025
a4fde79
swift-format 2
fabianfett Sep 25, 2025
2d54244
Merge branch 'main' into ff-structured-ServerChannel-bind
fabianfett Sep 25, 2025
b6563f5
Add ClientBootstrap methods.
fabianfett Sep 29, 2025
91c1ae3
ClientBootstrap structured as well
fabianfett Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Sources/NIOCore/AsyncChannel/AsyncChannel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,11 @@ public struct NIOAsyncChannel<Inbound: Sendable, Outbound: Sendable>: Sendable {
/// The stream of inbound messages.
///
/// - Important: The `inbound` stream is a unicast `AsyncSequence` and only one iterator can be created.
@available(*, deprecated, message: "Use the executeThenClose scoped method instead.")
public var inbound: NIOAsyncChannelInboundStream<Inbound> {
self._inbound
}

/// The writer for writing outbound messages.
@available(*, deprecated, message: "Use the executeThenClose scoped method instead.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we undeprecating these?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because we want to pass in the NIOAsyncChannel and users shall then use inbound and outbound on it. So that potentially we can add further properties to NIOAsyncChannel later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we undeprecate with an spi?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No you can't. What you can do is put it behind a trait like _ExperimentalStructuredBootstrap. You just have to duplicate the properties.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I intro new in and out properties and mark them with the same @_spi?

public var outbound: NIOAsyncChannelOutboundWriter<Outbound> {
self._outbound
}
Expand Down
Loading
Loading