Skip to content

Allow channel writes to be just sending and not Sendable #3384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Allow channel writes to be just sending and not Sendable #3384

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f451f43
Allow channel writes to be just sending and not Sendable
fabianfett Sep 30, 2025
5e5645c
use compiler ifs
fabianfett Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions Sources/NIOCore/Channel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,12 +158,26 @@ public protocol Channel: AnyObject, ChannelOutboundInvoker, _NIOPreconcurrencySe
@preconcurrency
func write<T: Sendable>(_ any: T) -> EventLoopFuture<Void>

#if compiler(>=6.0)
/// Write data into the `Channel`, automatically wrapping with `NIOAny`.
///
/// - seealso: `ChannelOutboundInvoker.write`.
func write<T>(_ any: sending T) -> EventLoopFuture<Void>
#endif

/// Write data into the `Channel`, automatically wrapping with `NIOAny`.
///
/// - seealso: `ChannelOutboundInvoker.write`.
@preconcurrency
func write<T: Sendable>(_ any: T, promise: EventLoopPromise<Void>?)

#if compiler(>=6.0)
/// Write data into the `Channel`, automatically wrapping with `NIOAny`.
///
/// - seealso: `ChannelOutboundInvoker.write`.
func write<T>(_ any: sending T, promise: EventLoopPromise<Void>?)
#endif

/// Write and flush data into the `Channel`, automatically wrapping with `NIOAny`.
///
/// - seealso: `ChannelOutboundInvoker.writeAndFlush`.
Expand Down
Loading