re-vendor sha1 & update script location #3400
Open
+23
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
reviewed
Oct 9, 2025
|
|
||
| #ifdef __cplusplus | ||
| extern "C" { | ||
| #endif |
There was a problem hiding this comment.
These changes are required for CXX interop.
There was a problem hiding this comment.
Oooh, are we compiling C headers in C++ mode for that?
There was a problem hiding this comment.
Unavoidably so, yeah. CXX interop is viral backwards through the dependency chain (i.e. if module X compiles in CXX mode then so does everything it depends on), so we have to tolerate the user switching that on when they use us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The sha1 vendoring script used the old place (
masterbranch). Also, the supposedly vendored copy had manual editsModifications:
Fix the vendoring script
Result:
Actually vendored and up to date