-
Notifications
You must be signed in to change notification settings - Fork 712
feat: Enable NIOFoundationCompat to compile using Swift for WebAssembly. Fix NIOCore WASI compilation issue. #3422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@MaxDesiatov @kateinoigakukun in case you're interested, I'm fixing Swift for WebAssembly compilation for NIOCore and NIOFoundationCompat in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, thanks!
|
This needs to be updated to the latest |
c99ee33 to
bf782d4
Compare
@Lukasa Ok, this should be rebased on the tip of main now. I'll work on getting you write access to the PR source branches. |
|
This PR has also fallen out of step with our |
bf782d4 to
453067a
Compare
@Lukasa This is now rebased on the latest I couldn't figure out the trick to give you write access to the branch short of adding you to our fork. I see evidence in web search results that there is a configuration to allow maintainers of the upstream fork to be able to push to PR source branches, but I can't seem to find the place to set up that configuration. If you know where I can configure that, can you send me a hint please? Happy to get that set up so you can rebase/merge as needed, and I am now prepared with admin credentials on our swift-nio fork to configure whatever is needed. |
Fix Swift for WebAssembly compilation in NIOFoundationCompat.
Motivation:
NIO is a common dependency, and it is important to enable compiling NIO using Swift for WebAssembly. This PR fixes compilation for NIOFoundationCompat.
Modifications:
Result:
With these changes, the following build commands succeed: ✅
Context:
This PR is part of a larger effort by PassiveLogic to improve Swift for WebAssembly support