Address potential template injection issues #3466
Open
+68
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
approved these changes
Dec 18, 2025
Member
|
@madrob Can you fix up the YAML lint? |
Contributor
Author
madrob
force-pushed
the
template-injection
branch
from
6e33b69 to
ce4d63b
Compare
Contributor
Author
|
@FranzBusch good to merge here now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of evaluating inputs directly in the run step, save them to an environment variable and evaluate that.
Motivation:
Evaluating workflow inputs directly can lead to injection attacks, such as those described at https://docs.zizmor.sh/audits/#template-injection
Modifications:
Evaluate workflow inputs as environment variables so that they do not inadvertently execute arbitrary shell injections.
Result:
The workflows should be more secure against malicious inputs.