-
Notifications
You must be signed in to change notification settings - Fork 722
Add ability to overwrite regular files and symbolic links in NIO FileSystem #3470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stepan-ulyanin
wants to merge
30
commits into
apple:main
Choose a base branch
from
stepan-ulyanin:su/add-overwriting-file-copy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add ability to overwrite regular files and symbolic links in NIO FileSystem #3470
stepan-ulyanin
wants to merge
30
commits into
apple:main
from
stepan-ulyanin:su/add-overwriting-file-copy
+620
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…py with overwrite
…opyFileOverwritingExistentDestination` test
…th a file and file with a symlink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new parameter to the NIOFS FileSystem's
copyItemthat allows to atomically overwrite regular files and symbolic links.Note that I opted in to not implement the overwrite for directories in this PR as it seems that there is no atomic way to overwrite directory trees on Posix systems - do we want to do it non-atomically?
Motivation:
Per #3403 it is not uncommon to want to copy an item and not care if the copied item overwrites an existing one.
Modifications:
overwriting: Boolparameter to NIOFS FileSystem'scopyItem.COPYFILE_UNLINKflag is added tocopyfile(2)rename(2)which overwrites an existing file or symbolic link._NIOFileSystemFileSystem'scopyItemfor backward compatibility.Tests
testCopyFileOverwritingExistingFiletestCopyFileOverwritingNonExistingFiletestCopyFileOverwritingCleansUpTempFiletestCopySymlinkOverwritingExistingSymlinktestCopySymlinkOverwritingNonExistingSymlinktestCopyFileOverwritingExistingSymlinktestCopySymlinkOverwritingExistingFileResult:
Users will be able to copy a regular file or a symbolic link, overwriting an existing regular file or existing symbolic link.