Add FreeBSD pthread support in ThreadPosix.swift#3593
Draft
rafaelcepeda wants to merge 12 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add FreeBSD thread naming and creation support to NIOPosix.
Motivation:
NIOPosix fails to compile on FreeBSD because
ThreadPosix.swifthas platform-specific handling for Linux, OpenBSD, and Darwin but FreeBSD falls through without definingThreadDestructor,sys_pthread_getname_np, orsys_pthread_setname_np. Thepthread_createcall also fails because FreeBSD'spthread_tis an opaque pointer type that can't be zero-initialized like on Linux.Modifications:
#elseif os(FreeBSD)block importingCNIOFreeBSDand wiringsys_pthread_getname_np/sys_pthread_setname_npto the C wrappers, with the appropriateThreadDestructortypealias.os(FreeBSD)to the existing OpenBSD guard insysPthread_create, since both BSDs use the same optionalpthread_attr_tpattern.Result:
ThreadPosix.swiftcompiles without errors on FreeBSD. Total NIOPosix error count drops from 89 to 75, eliminating all ThreadPosix-related errors.