Re-enable nightly-next Wasm Swift SDK CI for Swift 6.4#3620
Open
simonjbeaumont wants to merge 3 commits into
Open
Re-enable nightly-next Wasm Swift SDK CI for Swift 6.4#3620simonjbeaumont wants to merge 3 commits into
simonjbeaumont wants to merge 3 commits into
Conversation
Contributor
Author
|
Looks good (screenshot attached). Reverting the temporary branch swizzle |
…s PR branch" This reverts commit 0b760c0.
Contributor
Author
|
cc @MaxDesiatov |
Member
|
Wasm is not an acronym. Per the Wasm spec https://webassembly.github.io/spec/core/intro/introduction.html#wasm:
@simonjbeaumont Would you mind updating PR description and title before merging, so that commit history is clean? Thanks! |
simonjbeaumont
changed the title
Contributor
Author
Heh, sure. Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
#3619 moved the nightly-next Linux and Windows pipelines to Swift 6.4, but the Wasm Swift SDK pipeline was left behind -- its nightly-next job is still switched off. It was disabled in #3585 ("Disable nightly until 6.4 builds are available") when the 6.3 nightly artifacts were withdrawn, with a note to re-enable it once 6.4 builds landed. Those builds are now available.
There is also a latent issue that would bite as soon as the job is re-enabled: swift.org now keys its development-snapshot install API on the bare channel (e.g.
6.4.x), while the downloadable artifacts still live underswift-<channel>-branch. The pipeline was passingswift-6.4-branch, which the API no longer recognises, so the toolchain/SDK discovery ininstall_swift_sdk.shwould fail even with the job enabled.Modifications:
6.4.x).install_swift_sdk.shto map a release channel to its download path -- the dev-snapshot API uses the bare channel (6.4.x) while downloads live underswift-<channel>-branch;mainstill maps todevelopment.Result:
The nightly-next Wasm Swift SDK pipeline builds against Swift 6.4 again. The nightly-main and 6.3 release Wasm jobs are unaffected -- they resolve through the unchanged
developmentandswift-<version>-releasepaths respectively.Notes:
Opening this PR from non-fork branch so we can validate the changes on the PR itself.