Fix Linux allocation hook calloc overflow handling#3635
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Linux allocation-counting hook implements calloc by multiplying count and size before allocating, then zeroing the result unconditionally. If the multiplication overflows, the hook can allocate a smaller buffer than requested. If allocation fails, it can pass NULL to memset.
Modification
This checks for count/size overflow before multiplying, reuses the computed total size, and only zeroes memory after allocation succeeds.
Result
The Linux hook now follows calloc-style failure behavior for overflow and avoids zeroing a NULL pointer on allocation failure.
Validation