Normalize Android NDK download host tag#3636
Open
fallintoplace wants to merge 2 commits into
Open
Conversation
jakepetroules
approved these changes
Jul 2, 2026
jakepetroules
left a comment
Member
There was a problem hiding this comment.
This looks correct to me!
simonjbeaumont
approved these changes
Jul 2, 2026
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Android NDK download script builds the archive URL with the raw output of uname -s. The Android NDK downloads page documents lowercase host tags in archive names, for example android-ndk-r27d-linux.zip.
Google's download endpoint currently accepts the old Linux casing too, but using the documented host tag keeps the URL construction predictable and avoids relying on that behavior.
Modification
Map known host OS values to the Android NDK archive host tags before constructing the download URL:
Unknown host values now fail with a clear error instead of constructing a likely-bad URL.
Result
The installer uses documented Android NDK archive names across recognized hosts.
Validation