Use malloc zone for Darwin realloc hook#3637
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Darwin allocation-counting hook for malloc_zone_realloc accepted a malloc zone, but delegated to plain realloc. That ignored the zone argument and could reallocate through the wrong allocator for zone-specific allocation paths.
Modification
Call malloc_zone_realloc(zone, ptr, size) from replacement_malloc_zone_realloc.
This also adds a small Darwin C executable test target with a custom malloc zone. The test verifies that replacement_malloc_zone_realloc dispatches through the requested zone's realloc callback.
Result
Darwin zone-specific realloc calls now preserve the requested malloc zone while keeping the existing allocation/free counter behavior.
Validation